Review Request 109004: Improve TplQt4 CMakeLists.txt

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109004/#review27628
-----------------------------------------------------------


This review has been submitted with commit 5fc4c764a514b3cbd804088c454f2e7e40153ee0 by Dan Vrátil to branch master.

- Commit Hook


On Feb. 18, 2013, 11:39 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109004/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 11:39 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
>  1) Fix version check for telepathy-logger - cmake will now correctly fail if telepathy-logger>=0.8.0 is not available
>  2) Use set_package_properties() macro to nicely log optional/required/missing packages
> 
> (Using set_package_properties() requires at CMake>=2.8.6, but since kdepimlibs already require it for 4.10, it should not cause any trouble)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a2d457a 
>   cmake/modules/FindDBusGLib.cmake af4bbe8 
>   cmake/modules/FindQtGLib.cmake 0713164 
>   codegen/CMakeLists.txt bcf3ffe 
> 
> Diff: http://git.reviewboard.kde.org/r/109004/diff/
> 
> 
> Testing
> -------
> 
> Still compiles
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130218/b48bac51/attachment.html>