Review Request 109004: Improve TplQt4 CMakeLists.txt

Dan Vrátil dvratil at redhat.com
Mon Feb 18 11:39:45 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109004/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

 1) Fix version check for telepathy-logger - cmake will now correctly fail if telepathy-logger>=0.8.0 is not available
 2) Use set_package_properties() macro to nicely log optional/required/missing packages

(Using set_package_properties() requires at CMake>=2.8.6, but since kdepimlibs already require it for 4.10, it should not cause any trouble)


Diffs
-----

  CMakeLists.txt a2d457a 
  cmake/modules/FindDBusGLib.cmake af4bbe8 
  cmake/modules/FindQtGLib.cmake 0713164 
  codegen/CMakeLists.txt bcf3ffe 

Diff: http://git.reviewboard.kde.org/r/109004/diff/


Testing
-------

Still compiles


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130218/f8d30636/attachment-0001.html>


More information about the KDE-Telepathy mailing list