Review Request 109805: Properly calculate the edge where to put the dialog

Commit Hook null at kde.org
Fri Apr 5 17:39:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109805/
-----------------------------------------------------------

(Updated April 5, 2013, 5:39 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

Right now the approximation to decide where to put the popup was very rough. This didn't work that well with panels, especially the ones we were not controlling especifically (Top and Right). This patch addresses that by taking all them in account


Diffs
-----

  chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml 8a854b3 
  chat/org.kde.ktp-chat/contents/ui/main.qml 834ecaa 

Diff: http://git.reviewboard.kde.org/r/109805/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130405/186bd3b1/attachment.html>


More information about the KDE-Telepathy mailing list