Review Request 109805: Properly calculate the edge where to put the dialog

Commit Hook null at kde.org
Fri Apr 5 17:39:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109805/#review30482
-----------------------------------------------------------


This review has been submitted with commit 6a3235def3a300c461de6c3bf7d7d1bae29eab3f by Aleix Pol to branch master.

- Commit Hook


On March 30, 2013, 7:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109805/
> -----------------------------------------------------------
> 
> (Updated March 30, 2013, 7:45 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Right now the approximation to decide where to put the popup was very rough. This didn't work that well with panels, especially the ones we were not controlling especifically (Top and Right). This patch addresses that by taking all them in account
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml 8a854b3 
>   chat/org.kde.ktp-chat/contents/ui/main.qml 834ecaa 
> 
> Diff: http://git.reviewboard.kde.org/r/109805/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130405/051fe441/attachment.html>


More information about the KDE-Telepathy mailing list