Review Request 109492: Allow Rich Text in QML notifications plasmoid

[nucleo nucleo]

> On March 31, 2013, 10:19 p.m., Commit Hook wrote:
> > This review has been submitted with commit 81fd37ec62cf8f064996aac409e6808ec7916153 by David Edmundson to branch KDE/4.10.
> 
> nucleo nucleo wrote:
>     I still see popups with things like "<b>" with kde-workspace-4.10.2 and backported patch.
>     I use DBus based popups in KVIrc. When popup shown firs time "<b>" appears there but after popup disappears and I open it by pressing on notification widget popup shown fine without "<b>" and with bold text.
> 
> David Edmundson wrote:
>     It is not in 4.10.2, it is in what will be 4.10.3
> 
> nucleo nucleo wrote:
>     kde-workspace-4.10.2 built with backported patch

As I told, patch works but partially.
Here popup with text displayed correctly after pressing on notification widget http://i.imgur.com/ap9B8Su.png
But at first popup appeared with broken text http://i.imgur.com/kmXS6a0.png


- nucleo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109492/#review30191
-----------------------------------------------------------


On March 31, 2013, 10:19 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109492/
> -----------------------------------------------------------
> 
> (Updated March 31, 2013, 10:19 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Telepathy.
> 
> 
> Description
> -------
> 
> Allow Rich Text in QML Notification plasmoid
> 
> This matches behaviour of the notifications in 4.9 which used QLabel
> It fixes a problem we noticed in KTp in which we would see notifications with   > in the body as we deliberately try and keep formatting the same and be HTML safe.
> 
> I want to backport this to 4.10 branch
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ed8ed99f92b7b5e7c2b491bd8d13d3eadb3d65db 
> 
> Diff: http://git.reviewboard.kde.org/r/109492/diff/
> 
> 
> Testing
> -------
> 
> Emitted notifications which were known to trigger the bug.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130405/c93550b3/attachment-0001.html>