Review Request: Allow plugins to include js and css in the <head> section

Tue Sep 4 16:01:39 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106302/#review18511
-----------------------------------------------------------

You seem to have forgotten to rebase before submitting for review - made some of the changes difficult to see. 

The patch itself seems to be all good, apart from a few minor nitpicks. 
But like the last one, I still don't see exactly why you're doing all this? Are there any Filters that would directly benefit from this?
Also, how would this fare in the chat plasmoid, which can't execute javascript or use CSS?

lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/106302/#comment14607>

    why is this a kWarning?

lib/message-processor.cpp
<http://git.reviewboard.kde.org/r/106302/#comment14608>

    Wouldn't it be nicer to have both inner for loops in one outer for loop?

lib/message-processor.cpp
<http://git.reviewboard.kde.org/r/106302/#comment14609>

    Might want to consider using a QStringBuilder here

- Lasath Fernando

On Sept. 1, 2012, 9:18 a.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106302/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 9:18 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add required{Scripts,Stylesheest} methods to AbstractMessageFilter
> Add header method to MessageProcessor. This method returns a string that will be inserted in the <head> section of the chat view
> Inject the scripts and the css before the end of the head tag
> 
> 
> This addresses bug 305976.
>     http://bugs.kde.org/show_bug.cgi?id=305976
> 
> 
> Diffs
> -----
> 
>   config/kcm_ktp_chat_appearance.desktop b729bcec47514f163fb2a6668aedefda94d7d502 
>   config/kcm_ktp_chat_behavior.desktop 618601ceb87e7dd4d9088a6e642e7c3796382113 
>   config/kcm_ktp_chat_messages.desktop 1f303f856ed400ef1721735f0de0ff76d9691109 
>   filters/emoticons/ktptextui_message_filter_emoticons.desktop 0a585a7f8b3495e9d0435b163c28b13dda32c32d 
>   filters/formatting/ktptextui_message_filter_formatting.desktop c5c15acbbd00df73be6368d93d92df21a4b2952b 
>   filters/images/ktptextui_message_filter_images.desktop 822a7c626eb35fefa20c531a1b93c0fba96f5ce9 
>   lib/abstract-message-filter.h 7b60d4821955bbb17730d03b1a7443aa931ceb7e 
>   lib/abstract-message-filter.cpp 1f733e6606d3f8cdee85ae5d4db52a98411dcd2e 
>   lib/adium-theme-view.cpp df2b6d7677176a1385ce1f7eca490766cea7a7b3 
>   lib/ktptxtui_message_filter.desktop 907a0027eb371c55ec975b11419f8530fe1863a5 
>   lib/message-processor.h 6d2e1cac48ea9d07c21ce7a6cfae87b4adb37046 
>   lib/message-processor.cpp 9262d6934f1e0a6748fb1ea89f90dd6a0b4e3614 
>   logviewer/ktp-log-viewer.desktop df2a40a01a3649e1f9bb6d452348687401052530 
>   plasmoid/org.kde.ktp-chatplasmoid/metadata.desktop 6145f2d22ffb40caf24fae444dd0796979d980a8 
> 
> Diff: http://git.reviewboard.kde.org/r/106302/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120904/08bad2de/attachment.html>