<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106302/">http://git.reviewboard.kde.org/r/106302/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You seem to have forgotten to rebase before submitting for review - made some of the changes difficult to see.
The patch itself seems to be all good, apart from a few minor nitpicks.
But like the last one, I still don't see exactly why you're doing all this? Are there any Filters that would directly benefit from this?
Also, how would this fare in the chat plasmoid, which can't execute javascript or use CSS?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106302/diff/1/?file=82633#file82633line219" style="color: black; font-weight: bold; text-decoration: underline;">lib/adium-theme-view.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void AdiumThemeView::initialise(const AdiumThemeHeaderInfo &chatInfo)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">219</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kWarning</span><span class="p">()</span> <span class="o"><<</span> <span class="n">templateHtml</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why is this a kWarning?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106302/diff/1/?file=82636#file82636line67" style="color: black; font-weight: bold; text-decoration: underline;">lib/message-processor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString MessageProcessor::header()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_FOREACH</span> <span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">script</span><span class="p">,</span> <span class="n">filter</span><span class="o">-></span><span class="n">requiredScripts</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't it be nicer to have both inner for loops in one outer for loop?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106302/diff/1/?file=82636#file82636line83" style="color: black; font-weight: bold; text-decoration: underline;">lib/message-processor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString MessageProcessor::header()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">83</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">out</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"</span><span class="se">\n</span><span class="s"> <!-- The following scripts and stylesheets are injected here by the plugins --></span><span class="se">\n</span><span class="s">"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Might want to consider using a QStringBuilder here</pre>
</div>
<br />
<p>- Lasath</p>
<br />
<p>On September 1st, 2012, 9:18 a.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2012, 9:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add required{Scripts,Stylesheest} methods to AbstractMessageFilter
Add header method to MessageProcessor. This method returns a string that will be inserted in the <head> section of the chat view
Inject the scripts and the css before the end of the head tag
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305976">305976</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/kcm_ktp_chat_appearance.desktop <span style="color: grey">(b729bcec47514f163fb2a6668aedefda94d7d502)</span></li>
<li>config/kcm_ktp_chat_behavior.desktop <span style="color: grey">(618601ceb87e7dd4d9088a6e642e7c3796382113)</span></li>
<li>config/kcm_ktp_chat_messages.desktop <span style="color: grey">(1f303f856ed400ef1721735f0de0ff76d9691109)</span></li>
<li>filters/emoticons/ktptextui_message_filter_emoticons.desktop <span style="color: grey">(0a585a7f8b3495e9d0435b163c28b13dda32c32d)</span></li>
<li>filters/formatting/ktptextui_message_filter_formatting.desktop <span style="color: grey">(c5c15acbbd00df73be6368d93d92df21a4b2952b)</span></li>
<li>filters/images/ktptextui_message_filter_images.desktop <span style="color: grey">(822a7c626eb35fefa20c531a1b93c0fba96f5ce9)</span></li>
<li>lib/abstract-message-filter.h <span style="color: grey">(7b60d4821955bbb17730d03b1a7443aa931ceb7e)</span></li>
<li>lib/abstract-message-filter.cpp <span style="color: grey">(1f733e6606d3f8cdee85ae5d4db52a98411dcd2e)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(df2b6d7677176a1385ce1f7eca490766cea7a7b3)</span></li>
<li>lib/ktptxtui_message_filter.desktop <span style="color: grey">(907a0027eb371c55ec975b11419f8530fe1863a5)</span></li>
<li>lib/message-processor.h <span style="color: grey">(6d2e1cac48ea9d07c21ce7a6cfae87b4adb37046)</span></li>
<li>lib/message-processor.cpp <span style="color: grey">(9262d6934f1e0a6748fb1ea89f90dd6a0b4e3614)</span></li>
<li>logviewer/ktp-log-viewer.desktop <span style="color: grey">(df2a40a01a3649e1f9bb6d452348687401052530)</span></li>
<li>plasmoid/org.kde.ktp-chatplasmoid/metadata.desktop <span style="color: grey">(6145f2d22ffb40caf24fae444dd0796979d980a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106302/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>