Review Request: Allow plugins to include js and css in the <head> section

Fri Sep 21 09:29:13 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106302/
-----------------------------------------------------------

(Updated Sept. 21, 2012, 9:29 a.m.)

Review request for Telepathy.

Changes
-------

Fixed Lasath's issues...
See my comment about https://git.reviewboard.kde.org/r/106301/ about the reason why I'm doing this.

Regarding the chat plasmoid, I think that you can just avoid including them... you won't have proper formatting, but you are not expecting that in the chat plasmoid since it doesn't support the full set of html...

Description
-------

Add required{Scripts,Stylesheest} methods to AbstractMessageFilter
Add header method to MessageProcessor. This method returns a string that will be inserted in the <head> section of the chat view
Inject the scripts and the css before the end of the head tag

This addresses bug 305976.
    http://bugs.kde.org/show_bug.cgi?id=305976

Diffs (updated)
-----

  lib/abstract-message-filter.h 9e895c529778fcb49feb39c030eb717515311424 
  lib/abstract-message-filter.cpp 0cb0dc7742d7f6ab107062cf57cef39430503978 
  lib/adium-theme-view.cpp df2b6d7677176a1385ce1f7eca490766cea7a7b3 
  lib/message-processor.h 6d2e1cac48ea9d07c21ce7a6cfae87b4adb37046 
  lib/message-processor.cpp 28ed0028ac2b6f2c5da9658bb988414c375034ee 

Diff: http://git.reviewboard.kde.org/r/106302/diff/

Testing
-------

Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120921/4fb670d3/attachment.html>