Review Request: Improve contact list group header

[Bjoern Balazs]

> On Nov. 20, 2012, 6:44 a.m., David Edmundson wrote:
> > Screenshot: New group header
> > <http://git.reviewboard.kde.org>
> >
> >     Completely disagree with changing the orientation of this arrow.
> >     
> >     It's against all other treeviews (that I can see)
> 
> Martin Klapetek wrote:
>     Because all other treeviews have the arrow on the left. The arrow always points towards the "parent" item or the expanded content. Which is what it does here.
> 
> David Edmundson wrote:
>     Load up Amarok look at the top header that says "Local Collection"
> 
> Martin Klapetek wrote:
>     That doesn't mean it's correct. I'll add the usability folks then.

I do not think the orientation (left or roght) of the arrow has an impact on the actual usability (e.g. in terms of errors, speed etc). It should be handled consistantly throughout KDE - but as I am not aware of any other examples than the amarok one given above, this would set the standard - or does anyone know of any others?

Personnaly I think your solution is more logical than the amarok one. Getting even more personal, I would suggest to not use the arrow at all if we are not in a (obvious) treeview. I would prefer '+' resp. '-' to open up a completely new field :)

But again: I think consistency is the most import aspect here - so orient on whatever the standard is.


- Bjoern


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106763/#review20066
-----------------------------------------------------------


On Nov. 20, 2012, 10:40 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106763/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 10:40 a.m.)
> 
> 
> Review request for Telepathy and KDE Usability.
> 
> 
> Description
> -------
> 
> I made several improvements to the group header in contact list:
> 
>  1) Moved the expand sign to the right
>  2) Removed the tiny line
>  3) Made the account/group icon slightly bigger (has the same size as the avatar in normal mode; might need adjusting)
>  4) Aligned both the icon and the font with the contacts
>  5) Used background color from palette disabled:highlight and lighter by factor of 10
> 
> This is more a visual review request than a code, I tried with several default KDE color schemes and I think it looks good in all of them, see the screenshot below. Let me know what you think (and if possible try using the patch for a while yourself and see how it fits).
> 
> 
> Diffs
> -----
> 
>   abstract-contact-delegate.cpp f5f2a05 
> 
> Diff: http://git.reviewboard.kde.org/r/106763/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> New group header
>   http://git.reviewboard.kde.org/r/106763/s/757/
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121120/642b46f6/attachment.html>