<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106763/">http://git.reviewboard.kde.org/r/106763/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 20th, 2012, 6:44 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="http://git.reviewboard.kde.org/r/106763/s/757/" style="color: black; font-weight: bold; font-size: 9pt;">cl_new_header_composed.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/106763/s/757/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/cl_new_header_composed_454_146_35_25.png" style="border: 1px black solid;" alt="New group header"></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Completely disagree with changing the orientation of this arrow.
It's against all other treeviews (that I can see)</pre>
</blockquote>
<p>On November 20th, 2012, 10:22 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because all other treeviews have the arrow on the left. The arrow always points towards the "parent" item or the expanded content. Which is what it does here.</pre>
</blockquote>
<p>On November 20th, 2012, 10:28 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Load up Amarok look at the top header that says "Local Collection"</pre>
</blockquote>
<p>On November 20th, 2012, 10:38 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That doesn't mean it's correct. I'll add the usability folks then.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not think the orientation (left or roght) of the arrow has an impact on the actual usability (e.g. in terms of errors, speed etc). It should be handled consistantly throughout KDE - but as I am not aware of any other examples than the amarok one given above, this would set the standard - or does anyone know of any others?
Personnaly I think your solution is more logical than the amarok one. Getting even more personal, I would suggest to not use the arrow at all if we are not in a (obvious) treeview. I would prefer '+' resp. '-' to open up a completely new field :)
But again: I think consistency is the most import aspect here - so orient on whatever the standard is.</pre>
<br />
<p>- Bjoern</p>
<br />
<p>On November 20th, 2012, 10:40 a.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and KDE Usability.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2012, 10:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I made several improvements to the group header in contact list:
1) Moved the expand sign to the right
2) Removed the tiny line
3) Made the account/group icon slightly bigger (has the same size as the avatar in normal mode; might need adjusting)
4) Aligned both the icon and the font with the contacts
5) Used background color from palette disabled:highlight and lighter by factor of 10
This is more a visual review request than a code, I tried with several default KDE color schemes and I think it looks good in all of them, see the screenshot below. Let me know what you think (and if possible try using the patch for a while yourself and see how it fits).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>abstract-contact-delegate.cpp <span style="color: grey">(f5f2a05)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106763/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106763/s/757/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/cl_new_header_composed_400x100.png" style="border: 1px black solid;" alt="New group header" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>