Review Request: Remove broken option to chose between whether new incoming chats open in the most recently used window or the first activated window.

[David Edmundson]

> On Nov. 6, 2012, 7:53 a.m., Martin Klapetek wrote:
> > Wouldn't it be better to just implement the code?
> 
> David Edmundson wrote:
>     I'm not sure. If no-one ever noticed this was broken is it really a worthwhile option?
>     
>     Also, how?
> 
> Martin Klapetek wrote:
>     There was one report, but well, that's just one report...as for how - simple check for config file when creating new tab? But I don't know the code that well...
>     
>     Up to you.

There's 3 options currently:

 - Open in a new window
 - Open as a tab in the first opened window
 - Open as a tab in the most recently used window

The last two currently do exactly the same thing opening in the first window!

We have one open bug that "open in a new window" does not work. This (I think) is simply a bug that changes are not applied instantly. I was trying to fix that bug when I noticed this issue.

In this patch I change the options to

 - Open each chat in a new window
 - Open each chat in the same window

(now I think about it with my usability hat on, the default option should be top)

It's less trivial to keep track of which was the most recently used window, do-able, but as no-one uses this feature (because it doesn't exist) I'm not sure there's any need for more complicated options.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107204/#review21477
-----------------------------------------------------------


On Nov. 5, 2012, 7:33 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107204/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 7:33 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove broken option to chose between whether new incoming chats open in the most recently used window or the first created window.
> 
> The code to differentiate between the two options was never written and this should never have been released like this.
> 
> 
> Diffs
> -----
> 
>   app/telepathy-chat-ui.h 606b45e3e073f560fb2befa2f00b1d7ade874a5a 
>   app/telepathy-chat-ui.cpp e9a35e56a6e0bda67fd1fb9a62bbcf08adc9fd94 
>   config/behavior-config.cpp 6e78168f6879d51f729084e3594e15301ecb48a4 
>   config/behavior-config.ui 7b8e304ca3268d9eae248529bcfe381d3a83a46f 
> 
> Diff: http://git.reviewboard.kde.org/r/107204/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121107/739371b1/attachment.html>