Review Request: Remove broken option to chose between whether new incoming chats open in the most recently used window or the first activated window.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107204/#review21538
-----------------------------------------------------------

Ship it!


Damn, I didn't look at the diff just quickly at the summary and I thought you were removing all three options, my bad, sorry. This makes perfect sense.


app/telepathy-chat-ui.h
<http://git.reviewboard.kde.org/r/107204/#comment16744>

    As there is no first/second/last, would it make more sense to be renamed to "CurrentWindow"?


- Martin Klapetek


On Nov. 5, 2012, 7:33 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107204/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 7:33 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove broken option to chose between whether new incoming chats open in the most recently used window or the first created window.
> 
> The code to differentiate between the two options was never written and this should never have been released like this.
> 
> 
> Diffs
> -----
> 
>   app/telepathy-chat-ui.h 606b45e3e073f560fb2befa2f00b1d7ade874a5a 
>   app/telepathy-chat-ui.cpp e9a35e56a6e0bda67fd1fb9a62bbcf08adc9fd94 
>   config/behavior-config.cpp 6e78168f6879d51f729084e3594e15301ecb48a4 
>   config/behavior-config.ui 7b8e304ca3268d9eae248529bcfe381d3a83a46f 
> 
> Diff: http://git.reviewboard.kde.org/r/107204/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121107/a02a82f7/attachment-0001.html>