<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107204/">http://git.reviewboard.kde.org/r/107204/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 6th, 2012, 7:53 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Wouldn't it be better to just implement the code?</pre>
</blockquote>
<p>On November 6th, 2012, 8:47 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure. If no-one ever noticed this was broken is it really a worthwhile option?
Also, how?</pre>
</blockquote>
<p>On November 6th, 2012, 7:33 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There was one report, but well, that's just one report...as for how - simple check for config file when creating new tab? But I don't know the code that well...
Up to you.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's 3 options currently:
- Open in a new window
- Open as a tab in the first opened window
- Open as a tab in the most recently used window
The last two currently do exactly the same thing opening in the first window!
We have one open bug that "open in a new window" does not work. This (I think) is simply a bug that changes are not applied instantly. I was trying to fix that bug when I noticed this issue.
In this patch I change the options to
- Open each chat in a new window
- Open each chat in the same window
(now I think about it with my usability hat on, the default option should be top)
It's less trivial to keep track of which was the most recently used window, do-able, but as no-one uses this feature (because it doesn't exist) I'm not sure there's any need for more complicated options.</pre>
<br />
<p>- David</p>
<br />
<p>On November 5th, 2012, 7:33 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2012, 7:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove broken option to chose between whether new incoming chats open in the most recently used window or the first created window.
The code to differentiate between the two options was never written and this should never have been released like this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/telepathy-chat-ui.h <span style="color: grey">(606b45e3e073f560fb2befa2f00b1d7ade874a5a)</span></li>
<li>app/telepathy-chat-ui.cpp <span style="color: grey">(e9a35e56a6e0bda67fd1fb9a62bbcf08adc9fd94)</span></li>
<li>config/behavior-config.cpp <span style="color: grey">(6e78168f6879d51f729084e3594e15301ecb48a4)</span></li>
<li>config/behavior-config.ui <span style="color: grey">(7b8e304ca3268d9eae248529bcfe381d3a83a46f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107204/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>