Review Request: Improve contact list action tooltips

[Martin Klapetek]

> On July 15, 2012, 11:48 p.m., David Edmundson wrote:
> > Why can't we use KDualStateAction?
> > If that doesn't work, make our own action that does, and keeps everything self contained in the action.

If you mean KDualAction, we can't use it because it does not have "checked" property, it only changes icons/strings. The groups/accounts actually is dual action and should be used (we need icons), the show/hide offline is not dual action but one being turned on or off (checked or not).

And I don't think making own class just for one tooltip switch is worth the effort.


> On July 15, 2012, 11:48 p.m., David Edmundson wrote:
> > main-widget.h, line 110
> > <http://git.reviewboard.kde.org/r/105587/diff/1/?file=73015#file73015line110>
> >
> >     not used.

As if the description is not clear enough.. :P


> On July 15, 2012, 11:48 p.m., David Edmundson wrote:
> > main-widget.cpp, line 138
> > <http://git.reviewboard.kde.org/r/105587/diff/1/?file=73016#file73016line138>
> >
> >     Same string in two places? 
> >     
> >     Best case: translators do twice as much work
> >     
> >     Worst case: text is different on load and after you've toggled twice.
> >

Eek, that's totally wrong.


> On July 15, 2012, 11:48 p.m., David Edmundson wrote:
> > main-widget.cpp, line 562
> > <http://git.reviewboard.kde.org/r/105587/diff/1/?file=73016#file73016line562>
> >
> >     why do this?  You're doing two different things. Just have two slots.

Not really, it's the same thing with just different strings.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105587/#review15934
-----------------------------------------------------------


On July 15, 2012, 11:37 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105587/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 11:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This improves some tooltips over 'toolbar' actions in contact list, helps usability and accessibility.
> 
> I was about to use QSignalMapper, but the behavior would be the same except there would be one more connection and two more lines of code, which I think would help nothing, so I used just one simple slot.
> 
> Btw. ignore the signal mapper in the code, I just realized I left it there before uploading the patch, sorry about that.
> 
> 
> Diffs
> -----
> 
>   main-widget.h a3bab92 
>   main-widget.cpp 0c3eb97 
> 
> Diff: http://git.reviewboard.kde.org/r/105587/diff/
> 
> 
> Testing
> -------
> 
> Switched actions, looked at tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/663abb56/attachment-0001.html>