Review Request: Improve contact list action tooltips

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105587/#review15934
-----------------------------------------------------------


Why can't we use KDualStateAction?
If that doesn't work, make our own action that does, and keeps everything self contained in the action.


main-widget.h
<http://git.reviewboard.kde.org/r/105587/#comment12567>

    not used.



main-widget.cpp
<http://git.reviewboard.kde.org/r/105587/#comment12568>

    not used.



main-widget.cpp
<http://git.reviewboard.kde.org/r/105587/#comment12566>

    Same string in two places? 
    
    Best case: translators do twice as much work
    
    Worst case: text is different on load and after you've toggled twice.
    



main-widget.cpp
<http://git.reviewboard.kde.org/r/105587/#comment12565>

    why do this?  You're doing two different things. Just have two slots.


- David Edmundson


On July 15, 2012, 11:37 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105587/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 11:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This improves some tooltips over 'toolbar' actions in contact list, helps usability and accessibility.
> 
> I was about to use QSignalMapper, but the behavior would be the same except there would be one more connection and two more lines of code, which I think would help nothing, so I used just one simple slot.
> 
> Btw. ignore the signal mapper in the code, I just realized I left it there before uploading the patch, sorry about that.
> 
> 
> Diffs
> -----
> 
>   main-widget.h a3bab92 
>   main-widget.cpp 0c3eb97 
> 
> Diff: http://git.reviewboard.kde.org/r/105587/diff/
> 
> 
> Testing
> -------
> 
> Switched actions, looked at tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/fda906f7/attachment.html>