Review Request: Improve contact list action tooltips

[Martin Klapetek]

> On July 15, 2012, 11:48 p.m., David Edmundson wrote:
> > main-widget.cpp, line 562
> > <http://git.reviewboard.kde.org/r/105587/diff/1/?file=73016#file73016line562>
> >
> >     why do this?  You're doing two different things. Just have two slots.
> 
> Martin Klapetek wrote:
>     Not really, it's the same thing with just different strings.

Actually this issue will become irrelevant if I make the other action a KDualAction, then this slot will handle only the show/hide offline action.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105587/#review15934
-----------------------------------------------------------


On July 15, 2012, 11:37 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105587/
> -----------------------------------------------------------
> 
> (Updated July 15, 2012, 11:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This improves some tooltips over 'toolbar' actions in contact list, helps usability and accessibility.
> 
> I was about to use QSignalMapper, but the behavior would be the same except there would be one more connection and two more lines of code, which I think would help nothing, so I used just one simple slot.
> 
> Btw. ignore the signal mapper in the code, I just realized I left it there before uploading the patch, sorry about that.
> 
> 
> Diffs
> -----
> 
>   main-widget.h a3bab92 
>   main-widget.cpp 0c3eb97 
> 
> Diff: http://git.reviewboard.kde.org/r/105587/diff/
> 
> 
> Testing
> -------
> 
> Switched actions, looked at tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120716/e58a5c83/attachment.html>