Review Request: Improve contact list action tooltips

Martin Klapetek martin.klapetek at gmail.com
Sun Jul 15 23:37:56 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105587/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

This improves some tooltips over 'toolbar' actions in contact list, helps usability and accessibility.

I was about to use QSignalMapper, but the behavior would be the same except there would be one more connection and two more lines of code, which I think would help nothing, so I used just one simple slot.

Btw. ignore the signal mapper in the code, I just realized I left it there before uploading the patch, sorry about that.


Diffs
-----

  main-widget.h a3bab92 
  main-widget.cpp 0c3eb97 

Diff: http://git.reviewboard.kde.org/r/105587/diff/


Testing
-------

Switched actions, looked at tooltips.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/fe85b11b/attachment.html>


More information about the KDE-Telepathy mailing list