Review Request: Async Wallet Opening - Altnerate Version

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105567/#review15838
-----------------------------------------------------------


Oh well, I didn't see this one before commenting on the other one. This design is better imho, but it is still not thread safe. I don't think you need to share the wallet internally, one could simply share the WalletInterface externally.

My comment about the wallet failing to open still applies.

And another one, the destructor needs to become public here.

- George Kiagiadakis


On July 14, 2012, 1:01 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105567/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 1:01 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> I'm not 100% happy with the other patch, it's possible to 'forget' to call openWallet() and then it won't work very well.
> 
> so this was an alternate design I came up with. There's a static method to create a walletInterface instance that shares the same KWallet::Wallet (this is needed so we don't ask the user for wallet password twice). This object emits when it's ready.
> 
> Requires a lot more changing other code...personally I prefer https://git.reviewboard.kde.org/r/105566/ I just put this here for when someone asks "did I think of doing it this way". Will discard if the other one gets accepted.
> 
> 
> Diffs
> -----
> 
>   KTp/wallet-interface.h c43fb38 
>   KTp/wallet-interface.cpp d2dc2cb 
> 
> Diff: http://git.reviewboard.kde.org/r/105567/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/809770ae/attachment.html>