<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105567/">http://git.reviewboard.kde.org/r/105567/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh well, I didn't see this one before commenting on the other one. This design is better imho, but it is still not thread safe. I don't think you need to share the wallet internally, one could simply share the WalletInterface externally.
My comment about the wallet failing to open still applies.
And another one, the destructor needs to become public here.</pre>
<br />
<p>- George</p>
<br />
<p>On July 14th, 2012, 1:01 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 14, 2012, 1:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not 100% happy with the other patch, it's possible to 'forget' to call openWallet() and then it won't work very well.
so this was an alternate design I came up with. There's a static method to create a walletInterface instance that shares the same KWallet::Wallet (this is needed so we don't ask the user for wallet password twice). This object emits when it's ready.
Requires a lot more changing other code...personally I prefer https://git.reviewboard.kde.org/r/105566/ I just put this here for when someone asks "did I think of doing it this way". Will discard if the other one gets accepted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/wallet-interface.h <span style="color: grey">(c43fb38)</span></li>
<li>KTp/wallet-interface.cpp <span style="color: grey">(d2dc2cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105567/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>