Review Request: Create KCM to enable/disable MessageFilters
Lasath Fernando
kde at lasath.org
Sat Jul 14 12:36:37 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105571/
-----------------------------------------------------------
Review request for Telepathy.
Description
-------
I skimmed through BKO and I don't think there are any bugs about not being able to disable Message Filters :O
But anyway, this addresses that issue by building a KCM. There currently isn't any way of getting to it apart
from running kcmshell4 kcm_ktp_chat_messages (which only now occurred to me might be an issue).
When having to deal with only loading enabled plugins, the code in MessageProcessor started to get a little
horrific, so I split that off into a new class called PluginConfigManager.
Diffs
-----
lib/plugin-config-manager.h PRE-CREATION
lib/plugin-config-manager.cpp PRE-CREATION
config/messages-config.cpp PRE-CREATION
filters/emoticons/ktptextui_message_filter_emoticons.desktop 2626102
filters/formatting/format-filter.cpp b8f0b53
filters/formatting/ktptextui_message_filter_formatting.desktop 7dc8cb7
filters/images/ktptextui_message_filter_images.desktop 649f206
lib/CMakeLists.txt f172936
lib/message-processor.h 08cc386
lib/message-processor.cpp 926bef7
config/kcm_ktp_chat_messages.desktop PRE-CREATION
config/messages-config.h PRE-CREATION
config/CMakeLists.txt dbe0de9
Diff: http://git.reviewboard.kde.org/r/105571/diff/
Testing
-------
Passes unit tests when plugins are enabled, fails when they're not.
Thanks,
Lasath Fernando
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/3341e7d1/attachment.html>
More information about the KDE-Telepathy
mailing list