Review Request: QuickChat Plasmoid: Annoying weird button is annoying

[Aleix Pol Gonzalez]

> On July 13, 2012, 7:20 a.m., Lasath Fernando wrote:
> > Why does no-one like that button :-/
> > 
> > The part I'm not sure is a good idea is putting a ToolBar in a popout (I haven't seen anything else do that). Did it look really horrible with all those buttons above a separator?

>From my point of view, if we have components, we should use them. If they don't apply then the component should be fixed. Otherwise we won't ever make all plasmoids look alike...

If you prefer the former implementation, I can remove the change to ToolBar, no problem. I don't really have a say on the looks :).


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105542/#review15769
-----------------------------------------------------------


On July 13, 2012, 12:12 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105542/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 12:12 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Make the minimize button a separate button.
> Put all the top buttons in a toolbar.
> 
> 
> This addresses bug 293488.
>     http://bugs.kde.org/show_bug.cgi?id=293488
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 90cc07d 
> 
> Diff: http://git.reviewboard.kde.org/r/105542/diff/
> 
> 
> Testing
> -------
> 
> I talked to myself wisely.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/63d497cd/attachment-0001.html>