Review Request: QuickChat Plasmoid: Annoying weird button is annoying

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105542/#review15769
-----------------------------------------------------------


Why does no-one like that button :-/

The part I'm not sure is a good idea is putting a ToolBar in a popout (I haven't seen anything else do that). Did it look really horrible with all those buttons above a separator?

- Lasath Fernando


On July 13, 2012, 12:12 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105542/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 12:12 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Make the minimize button a separate button.
> Put all the top buttons in a toolbar.
> 
> 
> This addresses bug 293488.
>     http://bugs.kde.org/show_bug.cgi?id=293488
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 90cc07d 
> 
> Diff: http://git.reviewboard.kde.org/r/105542/diff/
> 
> 
> Testing
> -------
> 
> I talked to myself wisely.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120713/c9fa680d/attachment.html>