Review Request: QuickChat Plasmoid: Annoying weird button is annoying

[David Edmundson]

> On July 13, 2012, 7:20 a.m., Lasath Fernando wrote:
> > Why does no-one like that button :-/
> > 
> > The part I'm not sure is a good idea is putting a ToolBar in a popout (I haven't seen anything else do that). Did it look really horrible with all those buttons above a separator?
> 
> Aleix Pol Gonzalez wrote:
>     From my point of view, if we have components, we should use them. If they don't apply then the component should be fixed. Otherwise we won't ever make all plasmoids look alike...
>     
>     If you prefer the former implementation, I can remove the change to ToolBar, no problem. I don't really have a say on the looks :).

@Aleix - screenshots on visual changes in future please.

my POV:
Separate button for minimize is a massive +1. Annoying button was annoying, or at least ambiguous in what it's function was.

However, frame inside a frame is bad. Particularly with the ToolButtons, which are a frame inside a frame inside a frame. Very bad!
Padding on toolbar to the items is completely missing. Frame of the button should not touch the frame of the toolbar (on mouseover) and the fact the close button does on the top and bottom but not the right is so wrong.
(Sorry, I whinge about padding a lot.. not that it's currently in a good state)

I'm not sure the plasma component is designed for this use case of being a toolbar in a popup applet, no-one else does. It's more for the apps for Active, so whilst I agree with the "use the components!" mantra, I don't think it applies in this case.

@Lasath - you're component maintainer you have to make hard decisions, accept something you don't like, or rejecting someones patch (or say how to change it)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105542/#review15769
-----------------------------------------------------------


On July 14, 2012, 10:05 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105542/
> -----------------------------------------------------------
> 
> (Updated July 14, 2012, 10:05 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Make the minimize button a separate button.
> Put all the top buttons in a toolbar.
> 
> 
> This addresses bug 293488.
>     http://bugs.kde.org/show_bug.cgi?id=293488
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 90cc07d 
> 
> Diff: http://git.reviewboard.kde.org/r/105542/diff/
> 
> 
> Testing
> -------
> 
> I talked to myself wisely.
> 
> 
> Screenshots
> -----------
> 
> After
>   http://git.reviewboard.kde.org/r/105542/s/636/
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120714/0574b1ff/attachment.html>