Review Request: Implement Searchexpansion Filter

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105433/
-----------------------------------------------------------

(Updated July 12, 2012, 8:39 a.m.)


Review request for Telepathy.


Changes
-------

Address issues raised by Martin.


Description
-------

Even with all the mucking around I did, I still managed to get some work done today after all :)

Okay, this filter is fairly straightforward, it takes the whole message and sticks it through KUriFiler::filterSearchUri().

I had to make a slight tweak to Message so that it ignores leading and trailing whitespace. 

This does have a slight catch in that it runs after UrlFilter, so the URLs it sticks in aren't clickable. But since this is really meant for outgoing messages, I thought it wasn't a major requirement.


Diffs (updated)
-----

  filters/CMakeLists.txt 4560704 
  filters/searchexpansion/CMakeLists.txt PRE-CREATION 
  filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop PRE-CREATION 
  filters/searchexpansion/searchexpansion-filter.h PRE-CREATION 
  filters/searchexpansion/searchexpansion-filter.cpp PRE-CREATION 
  lib/message.cpp d0e62b4 
  tests/message-processor-basic-tests.h 35f931f 
  tests/message-processor-basic-tests.cpp 554ce1a 

Diff: http://git.reviewboard.kde.org/r/105433/diff/


Testing
-------

Passed Unit tests.


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120712/bd0d0908/attachment.html>