Review Request: Implement Searchexpansion Filter

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105433/#review15899
-----------------------------------------------------------

Ship it!



filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop
<http://git.reviewboard.kde.org/r/105433/#comment12555>

    You probably want 0.5 here ;)



filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop
<http://git.reviewboard.kde.org/r/105433/#comment12556>

    You're using LGPL



filters/searchexpansion/searchexpansion-filter.h
<http://git.reviewboard.kde.org/r/105433/#comment12557>

    Variable name please



filters/searchexpansion/searchexpansion-filter.cpp
<http://git.reviewboard.kde.org/r/105433/#comment12558>

    Do you need this?



lib/message.cpp
<http://git.reviewboard.kde.org/r/105433/#comment12559>

    I still don't agree with this, because you type something and the message is changed. Leading and trailing spaces are probably useless anyway, but...I don't know, I'll let component maintainer decide on this.


- Martin Klapetek


On July 12, 2012, 8:39 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105433/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 8:39 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Even with all the mucking around I did, I still managed to get some work done today after all :)
> 
> Okay, this filter is fairly straightforward, it takes the whole message and sticks it through KUriFiler::filterSearchUri().
> 
> I had to make a slight tweak to Message so that it ignores leading and trailing whitespace. 
> 
> This does have a slight catch in that it runs after UrlFilter, so the URLs it sticks in aren't clickable. But since this is really meant for outgoing messages, I thought it wasn't a major requirement.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt 4560704 
>   filters/searchexpansion/CMakeLists.txt PRE-CREATION 
>   filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop PRE-CREATION 
>   filters/searchexpansion/searchexpansion-filter.h PRE-CREATION 
>   filters/searchexpansion/searchexpansion-filter.cpp PRE-CREATION 
>   lib/message.cpp d0e62b4 
>   tests/message-processor-basic-tests.h 35f931f 
>   tests/message-processor-basic-tests.cpp 554ce1a 
> 
> Diff: http://git.reviewboard.kde.org/r/105433/diff/
> 
> 
> Testing
> -------
> 
> Passed Unit tests.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120715/18311066/attachment-0001.html>