Review Request: Implement Searchexpansion Filter

[Lasath Fernando]

> On July 5, 2012, 8:23 a.m., Martin Klapetek wrote:
> > filters/searchexpansion/CMakeLists.txt, line 5
> > <http://git.reviewboard.kde.org/r/105433/diff/1/?file=71198#file71198line5>
> >
> >     You don't need this if you have no ui files

Removed.

I originally had them in there in case these plugins end up needing their own config UI or something later on...


> On July 5, 2012, 8:23 a.m., Martin Klapetek wrote:
> > filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop, line 3
> > <http://git.reviewboard.kde.org/r/105433/diff/1/?file=71199#file71199line3>
> >
> >     Remove if you don't have any comment ;)

Removed. I thought that was one of those mandatory fields :S


> On July 5, 2012, 8:23 a.m., Martin Klapetek wrote:
> > filters/searchexpansion/searchexpansion-filter.cpp, line 40
> > <http://git.reviewboard.kde.org/r/105433/diff/1/?file=71201#file71201line40>
> >
> >     This basically logs messages to the command line. Paranoid people will kill you for this.

Only URLS... but I suppose you have a point.


> On July 5, 2012, 8:23 a.m., Martin Klapetek wrote:
> > lib/message.cpp, line 36
> > <http://git.reviewboard.kde.org/r/105433/diff/1/?file=71202#file71202line36>
> >
> >     What is the meaning of this?

This was so that messages like "  gg:kde" or "gg:kde "  won't get ignored.

On an unrelated note: It also fixes an issue with the chat plasmoid having double new lines.


- Lasath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105433/#review15398
-----------------------------------------------------------


On July 4, 2012, 8:36 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105433/
> -----------------------------------------------------------
> 
> (Updated July 4, 2012, 8:36 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Even with all the mucking around I did, I still managed to get some work done today after all :)
> 
> Okay, this filter is fairly straightforward, it takes the whole message and sticks it through KUriFiler::filterSearchUri().
> 
> I had to make a slight tweak to Message so that it ignores leading and trailing whitespace. 
> 
> This does have a slight catch in that it runs after UrlFilter, so the URLs it sticks in aren't clickable. But since this is really meant for outgoing messages, I thought it wasn't a major requirement.
> 
> 
> Diffs
> -----
> 
>   filters/searchexpansion/searchexpansion-filter.cpp PRE-CREATION 
>   filters/searchexpansion/searchexpansion-filter.h PRE-CREATION 
>   filters/CMakeLists.txt 4560704 
>   filters/searchexpansion/CMakeLists.txt PRE-CREATION 
>   filters/searchexpansion/ktptextui_message_filter_searchexpansion.desktop PRE-CREATION 
>   lib/message.cpp d0e62b4 
>   tests/message-processor-basic-tests.h 35f931f 
>   tests/message-processor-basic-tests.cpp 554ce1a 
> 
> Diff: http://git.reviewboard.kde.org/r/105433/diff/
> 
> 
> Testing
> -------
> 
> Passed Unit tests.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120712/e93141a5/attachment.html>