Review Request: Improve efficiency of MPRIS player detection in KTP

Alex Merry kde at randomguy3.me.uk
Wed Dec 12 12:03:11 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107675/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Currently, every time an MPRIS2-capable player appears on or disappears from D-Bus, KTP's MPRIS2 module re-scans the whole of D-Bus for players.  This patch makes it just deal with the player that appeared or disappeared.


Diffs
-----

  telepathy-mpris.h ccf913e 
  telepathy-mpris.cpp 726cfc8 

Diff: http://git.reviewboard.kde.org/r/107675/diff/


Testing
-------

Absolutely none.  I can't even compile the module on the machine I'm working on, but I know the design works because I've used it in other MPRIS2-based projects.  This should probably be treated more as a suggestion of how this should be done, rather than a final patch to apply.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121212/8185ec7b/attachment.html>


More information about the KDE-Telepathy mailing list