Review Request: Make it possible to start conversations from the Quick Chat plasmoid

Aleix Pol Gonzalez aleixpol at gmail.com
Tue Dec 18 23:33:02 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107811/
-----------------------------------------------------------

Review request for Telepathy and David Edmundson.


Description
-------

I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent.

The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts.


Diffs
-----

  plasmoid/declarative-plugin/conversations-model.h f9dc047 
  plasmoid/declarative-plugin/conversations-model.cpp faaa60b 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml PRE-CREATION 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml 8a8d851 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegateButton.qml PRE-CREATION 
  plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml feb766b 

Diff: http://git.reviewboard.kde.org/r/107811/diff/


Testing
-------

Very little, mostly sending this review for starting a discussion on where we'd like to go with this plasmoid.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121218/965b5190/attachment.html>


More information about the KDE-Telepathy mailing list