Review Request: Improve efficiency of MPRIS player detection in KTP

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107675/#review23607
-----------------------------------------------------------


I totally missed this patch (I think the mail to the mailing list didn't go through). Thanks for the suggestion, I've redone the detection already and I plan on rewriting this module completely.

- Martin Klapetek


On Dec. 12, 2012, 12:03 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107675/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 12:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Currently, every time an MPRIS2-capable player appears on or disappears from D-Bus, KTP's MPRIS2 module re-scans the whole of D-Bus for players.  This patch makes it just deal with the player that appeared or disappeared.
> 
> 
> Diffs
> -----
> 
>   telepathy-mpris.h ccf913e 
>   telepathy-mpris.cpp 726cfc8 
> 
> Diff: http://git.reviewboard.kde.org/r/107675/diff/
> 
> 
> Testing
> -------
> 
> Absolutely none.  I can't even compile the module on the machine I'm working on, but I know the design works because I've used it in other MPRIS2-based projects.  This should probably be treated more as a suggestion of how this should be done, rather than a final patch to apply.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121217/69c5d0f9/attachment.html>