Review Request: Add plasma-themeability to the menu on the presence applet

[Martin Klapetek]

> On Dec. 1, 2012, 4:11 p.m., Dan Vrátil wrote:
> > Nice work! 
> > 
> > This is not your fault, but whoever wrote the original getIcon() code obviously did not care much about coding style, so let's fix it now :)
> 
> Andromeda Galaxy wrote:
>     I actually did write that code, but I haven't been working on KTP for very long, so I didn't know all of the coding styles that you used. Could you direct me to a document that explains the style in more detail?

We're using the kdelibs coding style, which is described here - http://techbase.kde.org/Policies/Kdelibs_Coding_Style


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107545/#review22870
-----------------------------------------------------------


On Dec. 1, 2012, 5:39 p.m., Andromeda Galaxy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107545/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 5:39 p.m.)
> 
> 
> Review request for Telepathy and KDE Usability.
> 
> 
> Description
> -------
> 
> The Presence applet will show a Plasma-themed icon on the desktop now. However, the menu items for statuses are still all Oxygen, so the user experience is inconsistent -- if the user clicks on an icon for status, they won't get that icon on the toolbar. The attached diff, if applied to the master, will make it so that those menu items are also Plasma-themed.
> 
> 
> Diffs
> -----
> 
>   src/presenceapplet.h 78ccfbd 
>   src/presenceapplet.cpp 291cde4 
> 
> Diff: http://git.reviewboard.kde.org/r/107545/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> The plasma-themed applet
>   http://git.reviewboard.kde.org/r/107545/s/863/
> The presence dropdown on the contact list
>   http://git.reviewboard.kde.org/r/107545/s/864/
> 
> 
> Thanks,
> 
> Andromeda Galaxy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121201/0797a144/attachment.html>