<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107545/">http://git.reviewboard.kde.org/r/107545/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 1st, 2012, 4:11 p.m., <b>Dan Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice work!
This is not your fault, but whoever wrote the original getIcon() code obviously did not care much about coding style, so let's fix it now :)</pre>
</blockquote>
<p>On December 1st, 2012, 4:48 p.m., <b>Andromeda Galaxy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I actually did write that code, but I haven't been working on KTP for very long, so I didn't know all of the coding styles that you used. Could you direct me to a document that explains the style in more detail?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We're using the kdelibs coding style, which is described here - http://techbase.kde.org/Policies/Kdelibs_Coding_Style</pre>
<br />
<p>- Martin</p>
<br />
<p>On December 1st, 2012, 5:39 p.m., Andromeda Galaxy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and KDE Usability.</div>
<div>By Andromeda Galaxy.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2012, 5:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Presence applet will show a Plasma-themed icon on the desktop now. However, the menu items for statuses are still all Oxygen, so the user experience is inconsistent -- if the user clicks on an icon for status, they won't get that icon on the toolbar. The attached diff, if applied to the master, will make it so that those menu items are also Plasma-themed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/presenceapplet.h <span style="color: grey">(78ccfbd)</span></li>
<li>src/presenceapplet.cpp <span style="color: grey">(291cde4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107545/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107545/s/863/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/01/themed-presence-applet_1_400x100.png" style="border: 1px black solid;" alt="The plasma-themed applet" /></a>
<a href="http://git.reviewboard.kde.org/r/107545/s/864/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/01/unthemed-contact-list-dropdown_400x100.png" style="border: 1px black solid;" alt="The presence dropdown on the contact list" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>