Review Request: Add plasma-themeability to the menu on the presence applet

[Martin Klapetek]

> On Dec. 1, 2012, 5:44 p.m., Martin Klapetek wrote:
> > Usability folks - we have two sorts of presence menus, one is in the plasmoid, which is usually put in the systray and one in contact list. We recently added plasma themed presence icons for the plasmoid itself. This patch now adds those same plasma icons into the presence menu of the plasmoid, making this one looking different from the contact list one. Also, all other plasmoids use oxygen icons in their menus, so I'm inclined to keep the oxygen icons.
> > 
> > What's your opinion?
> 
> Thomas Pfeiffer wrote:
>     First of all: Why do the Plasma-themed icons have to look so different from the Oxygen ones? Who says that Plasma-themed icons have to be speech bubbles? Wouldn't monochromatic versions of the Oxygen icons work as well? The only problem I see is that online and invisible are currently only distinguishable by color (maybe we can ask nuno to come up with a different icon for invisible).
>     If they were had the same form, it would be far less confusing for users to see different icon sets as they should be able to easily recognize them.
> 
> Martin Klapetek wrote:
>     Good point. Thing is these icons are defined by Plasma theme. So if you change to a theme with these icons, there's not a lot we can do. Making the oxygen monochrome is actually very good idea. However let's consider these icons can be absolutely anything ;)
> 
> Thomas Pfeiffer wrote:
>     Oh yes, I forgot :( I'd suggest using monochrome Oxygen presence icons at least for the themes shipped by default with KDE, though.
>     
>     With the information "they could be anything" in mind, using the Plasma icons in the menu is the right choice in my opinion. They may look a bit alien in the menu because that's not what they're designed for, but since the presence icon changes after I click a menu entry with an icon attached to it, those icons should at least look similar. It would feel strange if a user clicks a menu entry with icon A and the Plasmoid changes to icon B which may look nothing like icon A. This would completely prevent visual recognition, which is the whole point of using icons (at least from a usability perspective).
>     With other Plasmoids this is not the problem, because the Plasmoid's look doesn't change with the icon clicked. And wherever they do, they do look similar.
>     See Amarok or Kopete, for example. Although I don't like Kopete's approach of attaching a tiny version of the Oxygen status icon to a generic Kopete icon (because it's hard to recognize the tiny status icon), at least it keeps consistency.
>     The fact that the contact list application uses different icons isn't of so much concern, because I assume that users either mostly use the Plasmoid to change status or the contact list, not both.
>     
>     And please change the icons in the Contact List Plasmoid as well, if that hasn't happened yet.

Thanks Thomas for your input! Ok to ship it then (I'll do that tomorrow).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107545/#review22881
-----------------------------------------------------------


On Dec. 1, 2012, 5:39 p.m., Andromeda Galaxy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107545/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 5:39 p.m.)
> 
> 
> Review request for Telepathy and KDE Usability.
> 
> 
> Description
> -------
> 
> The Presence applet will show a Plasma-themed icon on the desktop now. However, the menu items for statuses are still all Oxygen, so the user experience is inconsistent -- if the user clicks on an icon for status, they won't get that icon on the toolbar. The attached diff, if applied to the master, will make it so that those menu items are also Plasma-themed.
> 
> 
> Diffs
> -----
> 
>   src/presenceapplet.h 78ccfbd 
>   src/presenceapplet.cpp 291cde4 
> 
> Diff: http://git.reviewboard.kde.org/r/107545/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> The plasma-themed applet
>   http://git.reviewboard.kde.org/r/107545/s/863/
> The presence dropdown on the contact list
>   http://git.reviewboard.kde.org/r/107545/s/864/
> 
> 
> Thanks,
> 
> Andromeda Galaxy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121201/17ed4630/attachment.html>