<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106005/">http://git.reviewboard.kde.org/r/106005/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> if GTalk does it wrong I don't see any reason to copy.
But the name in the .desktop file is "Google Talk Style Formatting". The idea is so that what you see and send matches what the recipient sees and sends. Therefore we have to match exactly.
It was meant (in the original design) to be on an per-account basis, it probably does need a config with presets though. Lets try and get some sketches of that done.
Anyway, whilst the name remains as it does, they're choice of modifiers is "right", regardless of whether it's right or not.
>I don't know how to match a punctuation mark using QRegEx
[\D\W\S] should match anything that's not a digit, word or space. Though maybe need to invert the logic.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106005/diff/2/?file=81990#file81990line205" style="color: black; font-weight: bold; text-decoration: underline;">tests/message-processor-basic-tests.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MessageProcessorBasicTests::testRandomFormatting()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">164</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">compareWithPlainText</span><span class="p">(</span><span class="s">"*b*"</span><span class="p">,</span> <span class="s">"<b>*b*</b>"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You've changed the expected output here, now it's keeping the modifier character. (i.e the *s)
We can't go round changing the tests to match what the code does, that defeats the point of tests.
</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we've gone into this with different goals and idea of what should happen. If we go with this, the plugin name _needs_ to change.
(needs in this case is underlined btw :P )
A bit depends on what Lasath does in the meantime and on his comments.</pre>
<p>- David</p>
<br />
<p>On August 28th, 2012, 3:43 p.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Lasath Fernando.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2012, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests included and a few more visual test</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/message-processor-basic-tests.cpp <span style="color: grey">(a404908152ef9e21eb7e98cb472775f78c8a4162)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(ee7c23d612cbc737271798344b1939052e1b7326)</span></li>
<li>filters/formatting/format-filter.h <span style="color: grey">(4980aff8251a91b2e23de2a7d8257ed25b5d1322)</span></li>
<li>filters/formatting/format-filter.cpp <span style="color: grey">(75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1)</span></li>
<li>tests/message-processor-basic-tests.h <span style="color: grey">(5ffcc92864820d9fd8c535cd4e249cb31310011b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>