Review Request: (2/2) Improve groups expansion in contact list

[Martin Klapetek]

> On Aug. 14, 2012, 10:25 p.m., David Edmundson wrote:
> > contact-list-widget.cpp, line 801
> > <http://git.reviewboard.kde.org/r/106025/diff/1/?file=77772#file77772line801>
> >
> >     Surely you don't need this just after you've loaded it?
> >     And you don't really need the ref-counted version of KConfig

Hmm probably not. This method is called whenever you change the view from groups to accounts and vice versa and the original idea was to prevent cached values, which I was experiencing with this. But then I changed it to the QHash and left this in. I don't think it's relevant anymore, so I can just remove it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106025/#review17418
-----------------------------------------------------------


On Aug. 14, 2012, 10:17 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106025/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 10:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Improvements:
>  - always iterate over all the group/account items when the models change and expand the items accordingly
>  - keep the group states from config in memory, so we don't have to access the config so many times (it's called extensively)
> 
> 
> This addresses bug 304095.
>     http://bugs.kde.org/show_bug.cgi?id=304095
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h fd933df 
>   contact-list-widget.cpp 3809c24 
>   contact-list-widget_p.h 750eaf0 
> 
> Diff: http://git.reviewboard.kde.org/r/106025/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120815/792c2cb8/attachment.html>