Review Request: (2/2) Improve groups expansion in contact list

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106025/#review17418
-----------------------------------------------------------

Ship it!



contact-list-widget.cpp
<http://git.reviewboard.kde.org/r/106025/#comment13626>

    Surely you don't need this just after you've loaded it?
    And you don't really need the ref-counted version of KConfig


- David Edmundson


On Aug. 14, 2012, 10:17 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106025/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 10:17 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Improvements:
>  - always iterate over all the group/account items when the models change and expand the items accordingly
>  - keep the group states from config in memory, so we don't have to access the config so many times (it's called extensively)
> 
> 
> This addresses bug 304095.
>     http://bugs.kde.org/show_bug.cgi?id=304095
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h fd933df 
>   contact-list-widget.cpp 3809c24 
>   contact-list-widget_p.h 750eaf0 
> 
> Diff: http://git.reviewboard.kde.org/r/106025/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120814/53c79964/attachment.html>