Review Request: (2/2) Improve groups expansion in contact list
Martin Klapetek
martin.klapetek at gmail.com
Wed Aug 15 08:40:27 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106025/
-----------------------------------------------------------
(Updated Aug. 15, 2012, 8:40 a.m.)
Review request for Telepathy.
Changes
-------
- Read the config only in constructor
- Don't use ref counted kconfig
Description
-------
Improvements:
- always iterate over all the group/account items when the models change and expand the items accordingly
- keep the group states from config in memory, so we don't have to access the config so many times (it's called extensively)
This addresses bug 304095.
http://bugs.kde.org/show_bug.cgi?id=304095
Diffs (updated)
-----
contact-list-widget.h fd933df
contact-list-widget.cpp 3809c24
contact-list-widget_p.h 750eaf0
Diff: http://git.reviewboard.kde.org/r/106025/diff/
Testing
-------
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120815/7d92b34c/attachment.html>
More information about the KDE-Telepathy
mailing list