Review Request: Use Tp-Qt Factories

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104779/#review13175
-----------------------------------------------------------

Ship it!


Ship it.

Try and read up on the coding standard, and watch making random whitespace changes. There's a few occurrences, I've commented on one.



src/kwhiteboard-handler.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10268>

    coding standards
    
    do:
    x = y.
    
    not:
    x=y.



src/kwhiteboard-handler.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10266>

    I know this isn't your code.
    
    WTF is going on with this variable.
    
    If you could tidy this sort of thing up in a future patch that will really help you if you're hacking on it.



src/kwhiteboard-handler.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10267>

    I know this isn't your code.
    
    Leaks! 


- David Edmundson


On April 30, 2012, 8:44 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104779/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 8:44 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> This patch makes use of Tp-Qt factories to set up the telepathy client registrar in main.cpp
> I have used the codebase at http://quickgit.kde.org/index.php?p=kwhiteboard.git&a=summary
> 
> 
> Diffs
> -----
> 
>   src/kwhiteboard-handler.cpp d78b09e 
>   src/main.cpp 7e721f3 
> 
> Diff: http://git.reviewboard.kde.org/r/104779/diff/
> 
> 
> Testing
> -------
> 
> I have tested it and it runs successfully.
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120430/23a318a8/attachment.html>