Review Request: Use Tp-Qt Factories

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104779/#review13177
-----------------------------------------------------------

Ship it!


I pointed out few more code style issues. Also watch out for trailing whitespace (if you're using kdevelop, you can set it to automatically remove them for you).

You can read up on our coding style here -- http://techbase.kde.org/Policies/Kdelibs_Coding_Style


src/kwhiteboard-handler.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10270>

    And also the pointer sign (*) should be aligned to the variable itself, eg. Tp::Pen...ection *pendingConnection = m_outg....



src/kwhiteboard-handler.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10280>

    Watch out for indentation. Also try not to use too many useless debug messages in production code, it makes the debug output too noisy.



src/main.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10277>

    It's ok to leave a whitespace that visually separates one huge pile of code into smaller pieces that logically belong together. It makes orientation in the code easier ;)



src/main.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10272>

    Files should always have a new line at the end.


- Martin Klapetek


On April 30, 2012, 8:44 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104779/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 8:44 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> This patch makes use of Tp-Qt factories to set up the telepathy client registrar in main.cpp
> I have used the codebase at http://quickgit.kde.org/index.php?p=kwhiteboard.git&a=summary
> 
> 
> Diffs
> -----
> 
>   src/kwhiteboard-handler.cpp d78b09e 
>   src/main.cpp 7e721f3 
> 
> Diff: http://git.reviewboard.kde.org/r/104779/diff/
> 
> 
> Testing
> -------
> 
> I have tested it and it runs successfully.
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120430/71fbea45/attachment-0001.html>