Review Request: Use Tp-Qt Factories

Puneet Goyal puneetgoyal08 at gmail.com
Mon Apr 30 20:44:57 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104779/
-----------------------------------------------------------

(Updated April 30, 2012, 8:44 p.m.)


Review request for Telepathy and Daniele Elmo Domenichelli.


Changes
-------

there were two calls to the becomeready() function in kwhiteboard-handler.cpp that I removed. Also after removing them, there was no need of the functions onOutgoingTubeReady(Tp::PendingOperation* op) and onIncomingTubeReady(Tp::PendingOperation* op), so I removed them.


Description
-------

This patch makes use of Tp-Qt factories to set up the telepathy client registrar in main.cpp
I have used the codebase at http://quickgit.kde.org/index.php?p=kwhiteboard.git&a=summary


Diffs (updated)
-----

  src/kwhiteboard-handler.cpp d78b09e 
  src/main.cpp 7e721f3 

Diff: http://git.reviewboard.kde.org/r/104779/diff/


Testing
-------

I have tested it and it runs successfully.


Thanks,

Puneet Goyal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120430/c7f73ba8/attachment.html>


More information about the KDE-Telepathy mailing list