Review Request: Use Tp-Qt Factories

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104779/#review13063
-----------------------------------------------------------


The code is ok, but you are missing the point. The whole concept of factories is to avoid calling becomeReady() on objects and having slots that are asynchronously called when the requested features of those objects are ready. Therefore, you should also remove all calls to becomeReady() and any related slots and use the objects directly. The factories will then take care of enabling the requested features transparently.

- George Kiagiadakis


On April 29, 2012, 11:25 a.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104779/
> -----------------------------------------------------------
> 
> (Updated April 29, 2012, 11:25 a.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> This patch makes use of Tp-Qt factories to set up the telepathy client registrar in main.cpp
> I have used the codebase at http://quickgit.kde.org/index.php?p=kwhiteboard.git&a=summary
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 7e721f3 
> 
> Diff: http://git.reviewboard.kde.org/r/104779/diff/
> 
> 
> Testing
> -------
> 
> I have tested it and it runs successfully.
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120429/c6bc48ff/attachment.html>