Review Request: Fixes the bug that states when blocking a contact "typing" status should be cleared and two other bugfixes that was reported in the IRC.

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104451/#review12110
-----------------------------------------------------------



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104451/#comment9538>

    Have a look at how the actions are enabled/disabled the lines just before this, you should do the same to be coherent with the rest of the code.
    Or perhaps you can do everything (enable/disable and block/unblock) in the toggle method


Also please make 3 separate commits in your repository. Ping me on #kde-telepathy if you need help for that.

- Daniele Elmo Domenichelli


On April 2, 2012, 12:33 a.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104451/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 12:33 a.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Fixes the crash that happens when Blocking a contact during a group chat.
> Display to the user "The remote contact is blocked" string instead of the one that is printed when the user offline.
> Fixes Bug 297191 - When blocking a contact "typing" status should be cleared.
> 
> 
> This addresses bug 297191.
>     http://bugs.kde.org/show_bug.cgi?id=297191
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp ee62869 
>   lib/chat-widget.cpp cfbb74b 
> 
> Diff: http://git.reviewboard.kde.org/r/104451/diff/
> 
> 
> Testing
> -------
> 
> Blocked a user while typing status is displayed, the window title resets.
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120402/c4bca906/attachment.html>