Review Request: Fixes the bug that states when blocking a contact "typing" status should be cleared and two other bugfixes that was reported in the IRC.

[Martin Klapetek]

On March 31, 2012, 11:10 p.m., Ahmed Ibrahim wrote:
> > Also this time Martin will agree that the patch requires 3 separate commits, so push it somewhere this time :P
> > 
> > Related bugs are:
> > https://bugs.kde.org/show_bug.cgi?id=297187 Crash when blocking contact on group chats
> > https://bugs.kde.org/show_bug.cgi?id=297188 Sending a message to a blocked contact should report that the contact is blocked
> > https://bugs.kde.org/show_bug.cgi?id=297191 When blocking a contact "typing" status should be cleared
> 
> Ahmed Ibrahim wrote:
>     I've added a second diff update.
>     And I've pushed the changes to my github account 
>     https://github.com/R4md4c/ktp-text-ui

Well tbh I don't care that much, but DrDanz is probably right, you should have three separate patches - one for each fixed bug; your repo on github does not contain that but has only one commit. I suggest to reset to last upstream commit, then do 'git add -p file' and commit only the relevant fix and repeat for every bug. I can help with that, ping me on irc when I'm there.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104451/#review12083
-----------------------------------------------------------


On April 2, 2012, 12:33 a.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104451/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 12:33 a.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Fixes the crash that happens when Blocking a contact during a group chat.
> Display to the user "The remote contact is blocked" string instead of the one that is printed when the user offline.
> Fixes Bug 297191 - When blocking a contact "typing" status should be cleared.
> 
> 
> This addresses bug 297191.
>     http://bugs.kde.org/show_bug.cgi?id=297191
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp ee62869 
>   lib/chat-widget.cpp cfbb74b 
> 
> Diff: http://git.reviewboard.kde.org/r/104451/diff/
> 
> 
> Testing
> -------
> 
> Blocked a user while typing status is displayed, the window title resets.
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120402/5a60e0e4/attachment.html>