Review Request: Fixes the bug that states when blocking a contact "typing" status should be cleared and two other bugfixes that was reported in the IRC.

Ahmed Ibrahim ahmedibrahimkhali at gmail.com
Mon Apr 2 22:41:03 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104451/
-----------------------------------------------------------

(Updated April 2, 2012, 10:41 p.m.)


Review request for Telepathy and Daniele Elmo Domenichelli.


Changes
-------

Added a separate setBlockEnabled method to enables/disables the block action.


Description
-------

Fixes the crash that happens when Blocking a contact during a group chat.
Display to the user "The remote contact is blocked" string instead of the one that is printed when the user offline.
Fixes Bug 297191 - When blocking a contact "typing" status should be cleared.


This addresses bug 297191.
    http://bugs.kde.org/show_bug.cgi?id=297191


Diffs (updated)
-----

  app/chat-window.h fc5b26f 
  app/chat-window.cpp ee62869 
  lib/chat-widget.cpp cfbb74b 

Diff: http://git.reviewboard.kde.org/r/104451/diff/


Testing
-------

Blocked a user while typing status is displayed, the window title resets.


Thanks,

Ahmed Ibrahim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120402/be1a3d18/attachment.html>


More information about the KDE-Telepathy mailing list