Review Request: Load and save passwords to KWallet

[David Edmundson]

> On Sept. 30, 2011, 11:14 a.m., George Kiagiadakis wrote:
> > src/edit-account-dialog.cpp, line 131
> > <http://git.reviewboard.kde.org/r/102741/diff/2/?file=37721#file37721line131>
> >
> >     sigh, what a dreadful api... how many times is the word "wallet" repeated in this line? :P :P

9


> On Sept. 30, 2011, 11:14 a.m., George Kiagiadakis wrote:
> > src/edit-account-dialog.cpp, line 126
> > <http://git.reviewboard.kde.org/r/102741/diff/2/?file=37721#file37721line126>
> >
> >     You should remove the password from the setParameters before setting them to the account. If you do set them to the account, MC will still ask for gnome-keyring and if it doesn't find it, it will save the passwords in clear text inside its config file, which is unwanted.

I originally did this deliberately so it can keep both wallets up to date. If gnome keyring is not found it will simply silently not store the password. However you are correct it will pop-up a gnome-keyring dialog /if/ it's installed and it's not open.

I'll update it to be kwallet exclusively.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/#review6945
-----------------------------------------------------------


On Sept. 30, 2011, 9:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102741/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 9:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Load and save passwords to KWallet.
> 
> 
> Diffs
> -----
> 
>   src/add-account-assistant.cpp 43b55b6 
>   src/edit-account-dialog.cpp 8e9cde8 
> 
> Diff: http://git.reviewboard.kde.org/r/102741/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110930/37354f54/attachment.html>