Review Request: Load and save passwords to KWallet

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/#review6963
-----------------------------------------------------------



src/edit-account-dialog.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6152>

    I think this should be in the "onParameterUpdated" (in the AddAccountAssistant is in the onAccountCreated method), just to be sure that if something goes wrong in the update, we do't store a wrong password


For the rest it looks o, but before shipping I'd like to know what happens now if one has/doesn't have the gnome keyring installed and/or the auth handler? are the password always synchronized? which one takes precedence if for some reason they are different (i.e. one modifies the pw using empathy?)


- Daniele Elmo Domenichelli


On Sept. 30, 2011, 9:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102741/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 9:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Load and save passwords to KWallet.
> 
> 
> Diffs
> -----
> 
>   src/add-account-assistant.cpp 43b55b6 
>   src/edit-account-dialog.cpp 8e9cde8 
> 
> Diff: http://git.reviewboard.kde.org/r/102741/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110930/3ca8a1c5/attachment.html>