Review Request: Load and save passwords to KWallet

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/#review6945
-----------------------------------------------------------



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6136>

    Not very good. Afaiu, you save the password in MC first, then you copy it to kwallet. This isn't correct, MC should not be given any password, or else it will still open gnome-keyring...



src/edit-account-dialog.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6134>

    "telepathy-kde" or "kde-telepathy"? You use "kde-telepathy" in other functions. I agree with freinhard about a global constant, it would avoid these mistakes...



src/edit-account-dialog.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6135>

    You should remove the password from the setParameters before setting them to the account. If you do set them to the account, MC will still ask for gnome-keyring and if it doesn't find it, it will save the passwords in clear text inside its config file, which is unwanted.



src/edit-account-dialog.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6133>

    sigh, what a dreadful api... how many times is the word "wallet" repeated in this line? :P :P


- George Kiagiadakis


On Sept. 30, 2011, 9:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102741/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 9:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Load and save passwords to KWallet.
> 
> 
> Diffs
> -----
> 
>   src/add-account-assistant.cpp 43b55b6 
>   src/edit-account-dialog.cpp 8e9cde8 
> 
> Diff: http://git.reviewboard.kde.org/r/102741/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110930/cbb93814/attachment-0001.html>