Review Request: Load and save passwords to KWallet

[Florian Reinhard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/#review6944
-----------------------------------------------------------



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6132>

    what about a #define for the name, it appears quite often? besides all binaries are named telepathy-kde and the folder name is kde-telepathy, somehow inconsistent. couldn't the "kde-" just be removed? as a user i wouldn't care...


- Florian Reinhard


On Sept. 30, 2011, 9:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102741/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 9:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Load and save passwords to KWallet.
> 
> 
> Diffs
> -----
> 
>   src/add-account-assistant.cpp 43b55b6 
>   src/edit-account-dialog.cpp 8e9cde8 
> 
> Diff: http://git.reviewboard.kde.org/r/102741/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110930/99b341ee/attachment.html>