Review Request: Load and save passwords to KWallet

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/#review7012
-----------------------------------------------------------



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6183>

    This comment doesn't make sense... s/MC/kwallet/ ?



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6184>

    Maybe the reason it fails is that you save the password to kwallet only after the account is created. Did you check if the auth handler is spawned during account creation? Perhaps it is, but it finds no relevant password in kwallet and returns nothing...



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6185>

    This is definitely in wrong order. The CM will need the password when you set the account online, and you cannot be sure that you will manage to store the password in kwallet before the CM requests it...


There is also one thing remaining (which could be a different patch if you want): to remove the password from kwallet when the account is deleted.

- George Kiagiadakis


On Oct. 2, 2011, 2:27 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102741/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2011, 2:27 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Load and save passwords to KWallet.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f01cdf5 
>   src/add-account-assistant.cpp 43b55b6 
>   src/edit-account-dialog.cpp 8e9cde8 
>   src/wallet-interface.h PRE-CREATION 
>   src/wallet-interface.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102741/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111003/dd54c288/attachment.html>