Review Request: Load and save passwords to KWallet

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Sun Oct 2 16:03:06 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/#review7003
-----------------------------------------------------------



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6180>

    This is probably no longer needed



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6178>

    http://lists.freedesktop.org/archives/telepathy/2011-September/005747.html



src/add-account-assistant.cpp
<http://git.reviewboard.kde.org/r/102741/#comment6179>

    Perhaps for the moment you can add an if (!values.contains("register")) in order not to break registration for the 0.2 release? Otherwise we should remove the register button


- Daniele Elmo Domenichelli


On Oct. 2, 2011, 2:27 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102741/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2011, 2:27 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Load and save passwords to KWallet.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f01cdf5 
>   src/add-account-assistant.cpp 43b55b6 
>   src/edit-account-dialog.cpp 8e9cde8 
>   src/wallet-interface.h PRE-CREATION 
>   src/wallet-interface.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102741/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111002/1d3291f9/attachment.html>


More information about the KDE-Telepathy mailing list