Review Request: Load and save passwords to KWallet

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/
-----------------------------------------------------------

(Updated Oct. 4, 2011, 12:14 a.m.)


Review request for Telepathy.


Changes
-------

Hopefully addressed final comments.

Removing password code isn't really in the right place (it doesn't wait for account deletion to finish), but doing so would be extra complicated as we need a WinID for KWallet, and removal is all handled inside the model.

Either the model would need to emit a signal with the account removed, or other more involved hacks. Extra complication given this isn't ever really going to fail.


Description
-------

Load and save passwords to KWallet.


Diffs (updated)
-----

  src/CMakeLists.txt f01cdf5 
  src/add-account-assistant.cpp 43b55b6 
  src/edit-account-dialog.cpp 8e9cde8 
  src/kcm-telepathy-accounts.cpp a1d3172 
  src/wallet-interface.h PRE-CREATION 
  src/wallet-interface.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102741/diff/diff


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111004/fff514c0/attachment-0001.html>